[mypyc] Enable --strict-bytes by default in mypyc (and require it)#20548
Merged
Conversation
p-sawicki
approved these changes
Jan 8, 2026
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll be switching this on by default in mypy 2.0, but we can do it earlier in mypyc since backward compatibility requirements are not as strict. This makes the
bytesprimitive type not includebytearrayany more. This allows more efficient primitives and makes the semantics more consistent.I'll ensure that the bytes C primitives don't have dead bytearray code paths after this has been merged. I'll also add a separate bytearray primitive type at some point.