Move several command line tests to check tests#20646
Merged
Merged
Conversation
JukkaL
approved these changes
Jan 26, 2026
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for refactoring the tests! This should up running tests a bit. Looks good overall, just one optional comment that appears to be a pre-existing potential issue.
| g(None) # E: Argument 1 to "g" has incompatible type "None"; expected "list[Any]" | ||
| [file mypy.ini] | ||
| \[mypy] | ||
| allow_any_generics = True |
Collaborator
There was a problem hiding this comment.
I wonder if strict optional should also be disabled here, since there is a strict_optional = True below, and when this test was added, it's possible that strict optional was disabled by default.
hauntsaninja
commented
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authored by Codex