[codex] Add walrus allow-redefinition test#21660
Open
EltonChang1 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new unit test intended to cover the interaction between --allow-redefinition and assignment expressions used inside a list-comprehension-like construct, as discussed in #7314.
Changes:
- Adds a new
check-redefine2test case asserting that a walrus assignment can redefine a local variable’s type under--allow-redefinition. - Asserts that a subsequent reassignment can redefine the same variable again to a different type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused coverage for #7314 by testing how assignment expressions inside a list comprehension interact with
--allow-redefinition.The new case verifies that the comprehension result is inferred as
list[str], that mypy currently keeps the outer variable's revealed type asintafter the comprehension, and that a later assignment can still redefine it tofloatunder--allow-redefinition.Test Plan
.venv/bin/python -m pytest -n0 mypy/test/testcheck.py::TypeCheckSuite::check-redefine2.test -k testNewRedefineAssignmentExpressionComprehensions.venv/bin/python -m pytest -n0 mypy/test/testcheck.py::TypeCheckSuite::check-redefine2.test