Add NoArcadeWindowError subclassing RuntimeError #2784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add NoArcadeWindowError subclassing RuntimeError * Make arcade.window_commands.get_window() raise NoArcadeWindowError when no window exists * Add arcade.window_commands.have_window() function * Improve documentation of get_window() function
pushfoo
force-pushed
the
add_no_window_exception
branch
from
62798ce to
6183cdf
Compare
pushfoo
force-pushed
the
add_no_window_exception
branch
from
5d3d09b to
21420a8
Compare
pushfoo
changed the title
pushfoo
force-pushed
the
add_no_window_exception
branch
from
2c6df97 to
c38ba19
Compare
pushfoo
force-pushed
the
add_no_window_exception
branch
from
c38ba19 to
c190b44
Compare
Collaborator
DragonMoffon
left a comment
DragonMoffon
left a comment
There was a problem hiding this comment.
Documentation comment has the wrong function name, but this is otherwise good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Discord discussion with @DragonMoffon:
The function name is
have_windowin this PR but otherwise it's the same idea.Changes:
arcade.exceptions.NoArcadeWindowErrorRuntimeErrorarcade.window_commands:get_window()raiseNoArcadeWindowErrorwhen no window exists:returns:docstring forget_window()Deferred until a later PR:
has_window()somewherewindow_commandsmay be worth moving (especially if we add multi-window support?)