Revamp #22
Merged
Revamp #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more `self.page.document.baker.debug()` However, configuration instances log through their "parent", not directly (so PDFBakerPage uses `self.page.debug()`)
When did that get lost
Just missing the top level now
* Allow override of defaults (for library use, incl. our tests) * Improved logging for all log levels (incl. template rendering preview for --trace) * Teardown of top-level build directory * Minor tidy-ups/clarifications
pytest-cov and debugpy don't play
Click does the work, and doesn't care about return values. Also, we don't stop processing when one document fails, so we can see all problems not just one. So we need to error out if any of the documents failed.
We just tear down the document build dir at the end, no matter what. The way it was before it would tear down, _then_ show an error message if there was an error. Now the output is more logical. (sure, same result)
This looks correct now. A new document will start with a default config that includes e.g. the "pages" directory to be "pages". So this is in its base config, not in its own config - but it still is relative to its own config.
dannyadair
force-pushed
the
danny-revamp
branch
from
1fc9cac to
06c2c76
Compare
* Proper logging setup instead of basicConfig() * INFO and below to stdout, WARNING and above to stderr
If Ghostscript is not installed, will fall back to uncompressed. So it's ok to always give it a go.
Not the greatest of tests, but having 49 tests with a total test coverage of 91% is a good starting point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation still needs to be reviewed and adjusted for the new custom locations handling.