Open
Conversation
better handling of odd character!
siniorone
reviewed
Jan 30, 2022
| # load chat data | ||
| logger.info(f"Loading chat data from {chat_json}") | ||
| with open(chat_json) as f: | ||
| with open(chat_json, encoding='UTF8') as f: |
Collaborator
There was a problem hiding this comment.
Hello Ali and thanks for the PR.
Encoding of JSON files extracted from Telegram is UTF-8 and It is a good idea to identify the encoding of files when reading them. Thanks for this suggestion.
| :param text: Text that contains emoji | ||
| """ | ||
| regrex_pattern = re.compile(pattern="[\u2069\u2066]+", flags=re.UNICODE) | ||
| regrex_pattern = re.compile(pattern="[" |
Collaborator
There was a problem hiding this comment.
Since in the next line the demoji.replace(text, " ") is responsible for deleting all the emojis, we do not need to delete each emoji separately.
You can find the emojis that method demoji.replace() handles in the package document:
https://unicode.org/Public/emoji/14.0/emoji-sequences.txt
Collaborator
|
It is better to make changes in a branch and then send PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
better handling of odd character!