This repository was archived by the owner on Oct 1, 2020. It is now read-only.
Open
Conversation
hlu1
reviewed
Feb 26, 2019
Contributor
hlu1
left a comment
hlu1
left a comment
There was a problem hiding this comment.
Great work! Please add the benchmark part. I'll do a more detailed review later.
src/q8gemm/4x8-neon.c
Outdated
| } | ||
| } | ||
|
|
||
| void q8gemm_per_channel_ukernel_4x8__neon( |
Contributor
There was a problem hiding this comment.
Can you separate this part into a new file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preliminary version in order to get some feedback.
The goal is adding support in GEMM with different kernel quantization parameters per output channel.
Changes: