This repository was archived by the owner on Oct 1, 2020. It is now read-only.
Q8GEMM per-channel quant 32bit/16bit accumulation#54
Open
mortzur wants to merge 9 commits intopytorch:masterfrom
Open
Q8GEMM per-channel quant 32bit/16bit accumulation#54mortzur wants to merge 9 commits intopytorch:masterfrom
mortzur wants to merge 9 commits intopytorch:masterfrom
Conversation
This reverts commit 0b06799.
|
I believe the following patches are missing from the CMakeList.txt diff --git a/CMakeLists.txt b/CMakeLists.txt
index a5ddc49..6320b1e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -188,11 +188,15 @@ SET(QNNPACK_AARCH32_ASM_UKERNELS
src/q8conv/4x8-aarch32-neon.S
src/q8dwconv/up8x9-aarch32-neon.S
src/q8gemm/4x8-aarch32-neon.S
- src/q8gemm/4x8c2-xzp-aarch32-neon.S)
+ src/q8gemm/4x8c2-xzp-aarch32-neon.S
+ src/q8gemm/4x8-aarch32-neon-per-channel.S
+ src/q8gemm/4x8-aarch32-neon-per-channel-16bitAcc.S)
SET(QNNPACK_AARCH64_ASM_UKERNELS
src/q8conv/8x8-aarch64-neon.S
- src/q8gemm/8x8-aarch64-neon.S)
+ src/q8gemm/8x8-aarch64-neon.S
+ src/q8gemm/4x8-neon_per_channel.c
+ src/q8gemm/4x8-neon_per_channel_16bitAcc.c)
SET(QNNPACK_X86_SSE2_UKERNELS
src/q8avgpool/mp8x9p8q-sse2.c |
|
Also, Sorry, my bad. Only the benchmark is not compiling correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Micro-kernels implementation of the following:
Q8GEMM with per-channel weights quantization parameters (.c) + unit tests + benchmarks
Q8GEMM with per-channel weights quantization parameters for AARCH32 (.S) + unit tests + benchmarks
Q8GEMM with per-channel weights quantization parameters with 16bit opportunistic accumulation (.c) + unit tests + benchmarks
Q8GEMM with per-channel weights quantization parameters with 16bit opportunistic accumulation for AARCH32 (.S) + unit tests + benchmarks