Disallow additional properties on category schema #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonafato
force-pushed
the
no-additional-properties-category
branch
from
574bf3a to
705019c
Compare
jonafato
added a commit
that referenced
this pull request
Jun 21, 2025
Currently, the category schema definition file is included in the list of files that are validated against it. This causes validation errors when the schema validation's strictness is increased, e.g. by disallowing additional properties in #1172. This change excludes schema JSON files from the schema test script to resolve future validation errors.
jonafato
added a commit
that referenced
this pull request
Jun 21, 2025
Add start and end date fields as well as URL to the category schema. These properties are common across many categories supported here and already present in a handful of data files. This change also populates start and end date information based on the recording dates in video files for a couple of categories that have these fields present but do not pass the JSON Schema date format validation. References #268 and #1172.
jonafato
force-pushed
the
no-additional-properties-category
branch
from
705019c to
cef54d5
Compare
amyreese
pushed a commit
that referenced
this pull request
Jun 22, 2025
Currently, the category schema definition file is included in the list of files that are validated against it. This causes validation errors when the schema validation's strictness is increased, e.g. by disallowing additional properties in #1172. This change excludes schema JSON files from the schema test script to resolve future validation errors.
amyreese
pushed a commit
that referenced
this pull request
Jun 22, 2025
Add start and end date fields as well as URL to the category schema. These properties are common across many categories supported here and already present in a handful of data files. This change also populates start and end date information based on the recording dates in video files for a couple of categories that have these fields present but do not pass the JSON Schema date format validation. References #268 and #1172.
jonafato
force-pushed
the
no-additional-properties-category
branch
from
cef54d5 to
5cb4a1e
Compare
The intent of this change is to update the schema without any test failures. This means that other changes that affect the data should happen independently from the pull request associated with this commit, and it should be kept up to date and merged once the schema tests pass. To contribute to this change, open PRs that would correct any data that does not conform to the JSON schema. Discussion regarding other schema updates should happen in the associated issue at #1171. Resolves #1171.
jonafato
force-pushed
the
no-additional-properties-category
branch
from
5cb4a1e to
c577b3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this change is to update the schema without any test failures. This means that other changes that affect the data should happen independently from the pull request associated with this commit, and it should be kept up to date and merged once the schema tests pass. To contribute to this change, open PRs that would correct any data that does not conform to the JSON schema. Discussion regarding other schema updates should happen in the associated issue at #1171.
Resolves #1171.