Conversation
Apparently certain characters do not interact well with this .txt Substituted them with X to represent a bulletpoint
…moment. Possibly to be added later.
|
|
||
| LIBRARY PROGRAM CRITERIA | ||
|
|
||
| X The topic of seminar work can be either individually chosen or according to the rules below. |
There was a problem hiding this comment.
X is not valid Markdown, doesn't provide good structure to the README.
|
|
||
| CLASS STRUCTURE: | ||
|
|
||
| Overview of the int internalID in relation to classes and objects: |
| FalseDatabaseStarter.startDatabase(); | ||
|
|
||
|
|
||
| for (int i = 0; i < LibraryDatabase.getInventoryList().size(); i++) { |
There was a problem hiding this comment.
Consider enhanced list iteration like so: for (E element : LibraryDatabase.getInventoryList()) { /* do stuff with element */ }. It's much better than get(i).
| } | ||
| } | ||
| } | ||
|
|
| @@ -0,0 +1,21 @@ | |||
| Overview of the int internalID in relation to classes and objects: | |||
There was a problem hiding this comment.
same typo as before: int.
| } | ||
|
|
||
| public Inventory(int internalID, String type, String title, String availability) { | ||
| this.internalID = internalID; |
There was a problem hiding this comment.
internalID and type are equivalent, right? each type corresponds to one internalID only? Moreover, the concrete implementation of this abstract class already carries this distinction as an instance of a concrete class.
|
|
||
| } | ||
|
|
||
| static void addTouristGuide() { |
There was a problem hiding this comment.
there should definitely be a hierarchy of classes, where Novel, TouristGuide etc are concrete impls of a Book, etc.
| this.availability = availability; | ||
| } | ||
|
|
||
| public abstract StringBuilder returnFinalInfo(); |
There was a problem hiding this comment.
If you intend to add more to the returned FinalInfo, returning StringBuilder is fine, although the optimization that you get by using StringBuilder instead of String is completely irrelevant in your case: you are concatenating 20 strings at most.
I would imagine each of these two methods should return a string containing the info about the book. These are, effectively, public String toString() methods (don't forget to @Override). Add comments explaining what the difference between Raw and Final infos are.
|
|
||
| public class ArchiveFootage extends Video { | ||
| private boolean regionalHistory; | ||
| private boolean propaganda; |
|
|
||
| import inventory.FalseDatabaseStarter; | ||
| import inventory.Inventory; | ||
| import inventory.LibraryDatabase; |
There was a problem hiding this comment.
folder structure does not correspond to the package structure. Follow IntelliJ recommendations to move packages around.
3 participants
No description provided.