docs: document updateRtt side effect in ping method#20
Closed
Copilot wants to merge 4 commits intofeature/soonfrom
Closed
docs: document updateRtt side effect in ping method#20Copilot wants to merge 4 commits intofeature/soonfrom
Copilot wants to merge 4 commits intofeature/soonfrom
Conversation
Open
Co-authored-by: kamilsa <9370151+kamilsa@users.noreply.github.com>
Co-authored-by: kamilsa <9370151+kamilsa@users.noreply.github.com>
Co-authored-by: kamilsa <9370151+kamilsa@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on the SOON pull request
docs: document updateRtt side effect in ping method
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public
ping()method automatically updates the RTT repository on successful pings (added in commit 1dc4258), but this side effect was not documented in the API comments.Changes
ping()updates the RTT repository with measured round-trip time.gitignoreto exclude build artifacts (.venv,.vcpkg,.build)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.