Open
Conversation
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com> # Conflicts: # src/modules/networking/CMakeLists.txt
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
xDimon
force-pushed
the
feature/state_sync_client
branch
from
31754e0 to
65a6f34
Compare
xDimon
requested review from
kamilsa and
turuslan
and removed request for
kamilsa
turuslan
approved these changes
Feb 6, 2026
Comment on lines
+421
to
+424
| io.run(); | ||
|
|
||
| try { | ||
| return fut.get(); |
Contributor
There was a problem hiding this comment.
Does do_http_flow call io_context.stop() when completed?
Or did you test that this io_context.run() stops because there is no work guards and queue becomes empty?
Contributor
|
Testing and fixing in https://github.com/qdrvm/qlean-mini/tree/devnet2-checkpoint-sync |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
--state-sync-urlCLI-arg to provide URL for latest-finalized state syncing and use obtained state as an anchor state.