fix(config): use standalone bundled Node for runtime compatibility checks#326
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(config): use standalone bundled Node for runtime compatibility checks#326cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…ecks Standalone OpenClaw ships its own Node.js and openclaw.cmd prefers that binary over PATH. check_node() was inspecting the first system Node (often an older nvm install), marking compatible=false and blocking Gateway startup via ensure_node_runtime_compatible(). Prefer the bundled node next to the active standalone CLI when present, and mirror the same logic in dev-api web mode. Co-authored-by: 晴天 <1186258278@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Standalone OpenClaw installs bundle their own Node.js runtime. The
openclaw.cmdlauncher prefers%dp0%\node.exeover whatever is on PATH.Commit
634fe66addedensure_node_runtime_compatible()before Gateway startup, butcheck_node()still inspected the first system Node found on PATH (often an older nvm/fnm install). Users with standalone OpenClaw plus an outdated system Node were incorrectly blocked from starting Gateway with "Node.js version too low", even though the bundled runtime satisfied OpenClaw's requirement.Root cause
check_node()always usedfind_node_path()against enhanced PATH. For standalone users, this reported the system Node version instead of the bundled runtime that OpenClaw actually executes with.Fix
standaloneand a bundlednode/node.exeexists next to the CLI,check_node()now reports that binary's version and compatibility.scripts/dev-api.jsfor web/dev mode parity.Validation
node --check scripts/dev-api.jspassesnode_version_satisfies_requirementtests