clippy: Fix Clippy reports #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
force-pushed
the
pr/clippy-fixes
branch
from
924860c to
7740c56
Compare
See comments for 21b2e41 (".appveyor.yml: Update Rust version"). Signed-off-by: Quentin Monnet <qmo@qmon.net>
So we can use it instead of Error::new(ErrorKind::Other, ...) and tame Clippy's warnings. Signed-off-by: Quentin Monnet <qmo@qmon.net>
Actually, let Clippy fix most of these itself. I only removed the unused ErrorKind import from tests/misc.rs. Signed-off-by: Quentin Monnet <qmo@qmon.net>
qmonnet
force-pushed
the
pr/clippy-fixes
branch
from
7740c56 to
ed4b477
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, let Clippy fix most of these itself. I only removed the unused
ErrorKindimport from tests/misc.rs.