Fix/sandbox and web fixes#95
Conversation
…al mode When embedded VZ sandbox is not available (no kernel/rootfs configured), Bridge was incorrectly falling back to 127.0.0.1:19002, assuming a Docker sandbox was running. This caused Worker to send requests to a non-existent address, resulting in connection refused errors. Instead of hardcoding a fake address, switch execution mode back to local when sandbox is unavailable, ensuring file operations and shell commands run on the host machine. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… 19002
P0: Sidecar now auto-detects kernel/rootfs in ~/.arkloop/vm/ and sets
ARKLOOP_SANDBOX_KERNEL_IMAGE / ARKLOOP_SANDBOX_ROOTFS so that
StartEmbeddedSandbox() can actually launch the VZ VM pool.
P1: Remove desktopDockerSandboxAvailable()'s hardcoded health check to
127.0.0.1:19002. In Desktop mode there is no standalone Docker sandbox;
only VZ embedded sandbox exists. Also simplify desktopFirecrackerAvailable()
by removing the incorrect addr!=19002 guard.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
When VZ sandbox kernel/rootfs images are not found: - Sidecar now logs actionable hints to stdout showing where images should be placed (~/.arkloop/vm/) and that local mode will be used. - StartEmbeddedSandbox provides structured slog warnings with 'hint' and 'fallback' fields for easier debugging. This helps users understand why VM isolation is unavailable instead of silently falling back to local execution. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
TopLevelCopToolBlock rendered document_write tool cards with an empty
onClick={() => {}}, making them visually clickable but non-functional.
Fix:
- Add filename/title to GenericToolCallRef
- Add onOpenDocument prop through CopSegmentBlocks → TopLevelCopToolBlock
- Construct ArtifactRef from tool call args in document_write handler
- Wire onOpenDocument from MessageList and ChatView
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 107d740c5a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| key: filename, | ||
| filename, |
There was a problem hiding this comment.
When a document_write completes, the object is stored under the result artifact key (<account>/<run>/<filename> in document_write.Execute, not the bare filename). This click handler fabricates an ArtifactRef with key: filename, so opening any top-level document card fetches /v1/artifacts/<filename> and misses the stored object for normal account/run-scoped writes; use the artifact returned in call.result.artifacts[0] (or otherwise pass the real key) instead of the filename.
Useful? React with 👍 / 👎.
1 participant
修复了一些沙盒方面的错误代码和MD 文档无法打开右侧展示的问题