Conversation
Add GOOGLE_YIELDS and NUMPY_YIELDS as dedicated SyntaxKind variants, separate from GOOGLE_RETURNS and NUMPY_RETURNS. Previously, both Returns and Yields sections were represented by the same node kind (GOOGLE_RETURNS / NUMPY_RETURNS), making it impossible to distinguish them in the syntax tree without inspecting token text. This is problematic for linter use cases where the kind alone should suffice. Changes: - syntax.rs: add GOOGLE_YIELDS, NUMPY_YIELDS to SyntaxKind (enum, is_node(), name()) - parse/google/parser.rs: Yields section body now emits GOOGLE_YIELDS nodes - parse/numpy/parser.rs: add SectionBody::Yields variant, build_yields_node, process_yields_line to emit NUMPY_YIELDS nodes - parse/google/nodes.rs: add GoogleYields wrapper; GoogleSection::yields() - parse/numpy/nodes.rs: add NumPyYields wrapper; NumPySection::yields() - parse/google/to_model.rs: use section.yields() for Yields sections - parse/numpy/to_model.rs: use section.yields() for Yields sections - parse/google.rs, parse/numpy.rs: re-export new wrapper types - tests: update helpers and test_yields_section_body_variant to use yields() - bindings/python: add PyGoogleYields, PyNumPyYields, GOOGLE_YIELDS, NUMPY_YIELDS, yields getter on GoogleSection/NumPySection; update .pyi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.