Open
Conversation
There was a problem hiding this comment.
Pull request overview
Improves the Settings UI initialization by ensuring the proxy OptionButton is populated at runtime so the saved proxy setting can be selected correctly.
Changes:
- Populate
ProxyOptionListfrom_proxy_optionsduring_ready(). - Select the persisted proxy option index after populating the dropdown.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+50
to
+51
| for option in _proxy_options: | ||
| %ProxyOptionList.add_item(option) |
There was a problem hiding this comment.
ProxyOptionList is being populated with the raw internal values (off/on/download), which will show those identifiers in the UI instead of the localized/user-friendly strings already present in text/*/settings_tab.csv (e.g. obtn_proxy_option_off/on/download). Consider clearing the OptionButton first and adding translated display labels (while keeping the mapping to _proxy_options for persistence).
Suggested change
| for option in _proxy_options: | |
| %ProxyOptionList.add_item(option) | |
| %ProxyOptionList.clear() | |
| for option in _proxy_options: | |
| var label := tr("obtn_proxy_option_" + option) | |
| %ProxyOptionList.add_item(label) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small improvement to the
SettingsUIby ensuring that the proxy options are dynamically added to the proxy option dropdown list when the UI is initialized.scripts/SettingsUI.gd, the_ready()function now adds all available proxy options from_proxy_optionsto theProxyOptionListUI element, ensuring the dropdown is populated correctly.Generated By AI