Add options to Layout #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add format direction - extract options into constant.
Conflicts: lib/motion-layout/layout.rb
Owner
|
Hey there, I'm looking for a new maintainer for this. Can you check out #13? |
Author
|
no longer using rubymotion in production... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allow user to set options in
NSLayoutConstraint#constraintsWithVisualFormat:options:metrics:views:with simple symbol (like:left,:right,:trailing... etc), and by default use option 0 (same as that inNSLayoutConstraint#constraintsWithVisualFormat:options:metrics:views:).This patch is necessary because in many use case, the current option
NSLayoutFormatAlignAllCenterXandNSLayoutFormatAlignAllCenterYwill cause conflicts.This is based on @wejn patch, added document and examples, and merge with head. Please consider merging this, thank you!