Fix: AudioPlayback no longer requires network when clips exist #231
Conversation
tmoida
force-pushed
the
main
branch
2 times, most recently
from
5edc97f to
7fbc036
Compare
Runner/suites/Multimedia/Audio/AudioPlayback/AudioPlayback.yaml
Outdated
Show resolved
Hide resolved
|
Hi @smuppand, I've made the changes as requested. Here's what I did: Changes MadeI removed the SSID and PASSWORD from the YAML file since we don't want WiFi credentials hardcoded there. Instead, I added support for CI to provide a custom location for the audio clips. Files modified:
Please review and let me know if any other changes are required. |
tmoida
force-pushed
the
main
branch
2 times, most recently
from
9b78678 to
bbe9d8c
Compare
|
Hi @smuppand , I've addressed all the feedback you provided. Here's what was fixed: Changes made:
Please review and let me know if any other changes are required. |
| if [ -n "${AUDIO_CLIPS_BASE_DIR}" ]; then | ||
| ./run.sh --backend "${AUDIO_BACKEND}" --sink "${SINK_CHOICE}" --formats "${FORMATS}" --durations "${DURATIONS}" --loops "${LOOPS}" --timeout "${TIMEOUT}" --audio-clips-path "${AUDIO_CLIPS_BASE_DIR}" || true | ||
| else | ||
| ./run.sh --backend "${AUDIO_BACKEND}" --sink "${SINK_CHOICE}" --formats "${FORMATS}" --durations "${DURATIONS}" --loops "${LOOPS}" --timeout "${TIMEOUT}" || true |
There was a problem hiding this comment.
Keep only one invocation.
There was a problem hiding this comment.
Cleaned up the YAML as requested - no more duplicate run.sh calls. The script already checks if AUDIO_CLIPS_BASE_DIR is set, so we can always pass --audio-clips-path and let it handle the logic internally.
mwasilew
left a comment
mwasilew
left a comment
There was a problem hiding this comment.
Please make the commit title more descriptive. The resolves part should not be in the title.
| EXTRACT_AUDIO_ASSETS: true # Download/extract audio assets if missing, default: true | ||
| SSID: "" # Wi-Fi SSID for network connection, default: unset | ||
| PASSWORD: "" # Wi-Fi password for network connection, default: unset | ||
| ENABLE_NETWORK_DOWNLOAD: false # Enable network download of missing audio files, default: false |
There was a problem hiding this comment.
you still need SSID and PASSWORD if the network is enabled.
There was a problem hiding this comment.
Hi @mwasilew,
Thanks for the feedback. Fixed both issues:
- Made the commit title more descriptive
- SSID/PASSWORD: Added them back to the YAML params and run command - definitely needed for network download scenarios
Please review and let me know if any other changes are required.
- Add --enable-network-download flag (default: disabled) for offline-first operation - Implement smart network gating: only connect when clips missing AND download enabled - Add audio_check_clips_available() to validate clips before any network operations - Remove duplicate asset fetch logic from per-test loop (single download at startup) - Add --audio-clips-path flag for CI workflows with pre-staged clips - Add SSID/PASSWORD parameters for network authentication when download enabled This allows tests to run offline when clips are present, while providing network download capability when explicitly enabled with proper credentials. Resolves qualcomm-linux#229 Signed-off-by: Teja Swaroop Moida <tmoida@qti.qualcomm.com>
3 participants
Resolves #229
Problem:
AudioPlayback test was forcing network connections even when audio files were already present locally, causing tests to fail in offline environments.
Solution: