Fix: Emit diagnostic when LMA is unaligned#1088
Open
shauryarane05 wants to merge 2 commits into
Open
Conversation
shauryarane05
force-pushed
the
fix-issue-444-lma-unaligned-diagnostic
branch
from
670594b to
a4c040e
Compare
Author
|
fixed a clang-format issue flagged by CI (cosmetic line-break only, no logic change) |
quic-areg
reviewed
Apr 23, 2026
Currently eld does not warn when a section's load memory address (LMA) is not a multiple of its alignment, e.g. when AT() specifies an unaligned address. Emit the warn_lma_not_aligned warning in GNULDBackend::postLayout(), mirroring the existing VMA-alignment check added in e09c562. Fixes qualcomm#444 Signed-off-by: Shaurya Rane <ssrane_b23@ee.vjti.ac.in>
shauryarane05
force-pushed
the
fix-issue-444-lma-unaligned-diagnostic
branch
from
a4c040e to
52e9aa9
Compare
quic-seaswara
approved these changes
Apr 24, 2026
Author
|
Does this need changes or can it be merged? |
quic-areg
approved these changes
May 7, 2026
Contributor
|
@shauryarane05 can you resolve the conflicts and update the PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently eld does not warn when a section's load memory address (LMA) is not a multiple of its alignment, like when AT() specifies an unaligned address.Added a warning in GNULDBackend::postLayout() to catch when the LMA isn’t properly aligned , mirroring the existing VMA-alignment check added in e09c562.
Fixes #444