test: add test for anonymous version definition diagnostic#1152
Closed
sai18022001 wants to merge 4 commits into
Closed
test: add test for anonymous version definition diagnostic#1152sai18022001 wants to merge 4 commits into
sai18022001 wants to merge 4 commits into
Conversation
- Add tests for --section-start, -Ttext, -Tdata, -Tbss, -Ttext-segment - Add -Trodata-segment and -Tldata-segment support and tests - Update userguide with option descriptions Resolves qualcomm#1099 Signed-off-by: Sai Sanjay Chikne <saichikne180201@gmail.com>
…options - Add tests for --section-start, -Ttext, -Tdata, -Tbss, -Ttext-segment - Add -Trodata-segment and -Tldata-segment support and tests - Implement -Ttext-segment, -Trodata-segment, -Tldata-segment options - Update userguide with option descriptions Resolves qualcomm#1099 Signed-off-by: Sai Sanjay Chikne <saichikne180201@gmail.com>
Signed-off-by: Sai Sanjay Chikne <saichikne180201@gmail.com>
Add a lit test covering the error diagnostic emitted when an
anonymous version definition is used in combination with other
named version definitions in a version script.
The diagnostic is emitted in ScriptParser::readVersionScriptCommand()
when the parser encounters an anonymous block '{' after one or more
named version nodes in the same version script file.
Test location: test/Common/standalone/VersionScriptAnonymousMixed/
Fixes qualcomm#1124
Signed-off-by: Sai Sanjay Chikne <saichikne180201@gmail.com>
Author
|
Closing this PR due to unintentional commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1124
Adds a lit test covering the error diagnostic emitted when an anonymous
version definition is used in combination with other named version
definitions in a version script.
Problem :
The diagnostic
anonymous version definition is used in combination with other version definitions(emitted inScriptParser::readVersionScriptCommand())had no test coverage.
Solution :
Added a new lit test at
test/Common/standalone/VersionScriptAnonymousMixed/with the following files:
Inputs/1.c— minimal C source file to produce an object file for linkingInputs/vs_mixed— version script mixing a named and anonymous version node to trigger the diagnosticVersionScriptAnonymousMixed.test— compiles1.cinto an object file,links it as a shared library with
vs_mixedvia--version-script=,expects the link to fail (
%not), and verifies the error message usingFileCheckTesting :
Tested on AArch64, ARM, RISCV, RISCV64 — all pass.
x86 is marked
UNSUPPORTEDconsistent with other version script tests.Hexagon failure is a local toolchain issue (
-mv75unsupported), confirmed the same failure occurs on existing tests likeVersionScriptAnonymousTagMerge.