Add run test framework for ARM, AArch64, RISCV32 and RISCV64#1157
Open
parth-07 wants to merge 1 commit into
Open
Add run test framework for ARM, AArch64, RISCV32 and RISCV64#1157parth-07 wants to merge 1 commit into
parth-07 wants to merge 1 commit into
Conversation
69bcc6a to
d667847
Compare
d667847 to
c04ed36
Compare
c04ed36 to
81e3dcd
Compare
bbe2c71 to
965ed02
Compare
quic-seaswara
requested changes
May 12, 2026
97bba44 to
af932c9
Compare
af932c9 to
c92cfed
Compare
Contributor
|
Probably complete the list with adding X86 so that we have a stable sysroot to test with. |
362cef8 to
a136786
Compare
Contributor
Author
I have added x86-64 cross-toolchain as well. |
a136786 to
71f9907
Compare
quic-areg
reviewed
May 13, 2026
quic-areg
reviewed
May 13, 2026
quic-areg
reviewed
May 13, 2026
70893f7 to
b076a70
Compare
This commit adds the run test framework for ARM, AARch64, RISCV32, RISCV64 and x86-64. Additionally, it modifies the ci.yaml such that the tools requirements to enable run tests for these targets is available. The added HelloWorld and HelloWorldCXX test are marked XFAIL for the riscv target because of eld bugs. QEMU is crashing for static hello world program likely because of missing IFunc support and linker is unable to find a shared library that is indeed present in the sysroot for the dynamic hello world program. The HelloWorld and HelloWorldCXX test are marked UNSUPPORTED for x86-64 because this test is passing on release builds but is causing a linker crash on builds with assertions enabled. The crash is happening when reading the compressed sections. It cannot be marked as XFAIL because the test will pass on the CI builder, and will cause the 'check-eld' step to fail. Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
b076a70 to
4b549f3
Compare
quic-seaswara
requested changes
May 14, 2026
quic-seaswara
approved these changes
May 14, 2026
Contributor
|
I prefer we use environment variables instead of cmake variables since it affects a small subset. quickly changing the environment and running is so much easy. We do need a blanket option in cmake to enable/disable run tests completely though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the run test framework for ARM, AARch64, RISCV32,
RISCV64 and x86-64. Additionally, it modifies the ci.yaml such that the tools
requirements to enable run tests for these targets is available.
The added HelloWorld and HelloWorldCXX test are marked XFAIL for the riscv target
because of eld bugs. QEMU is crashing for static hello world program likely
because of missing IFunc support and linker is unable to find a shared library that is
indeed present in the sysroot for the dynamic hello world program.
The HelloWorld and HelloWorldCXX test are marked UNSUPPORTED for x86-64
because this test is passing on release builds but is causing a
linker crash on builds with assertions enabled. The crash is happening
when reading the compressed sections. It cannot be marked as XFAIL
because the test will pass on the CI builder, and will cause the
'check-eld' step to fail.