Interactive coverage#59
Merged
Merged
Conversation
Signed-off-by: Zeev Belinsky <zbelinsk@qti.qualcomm.com>
…raphs
- New cov_html_report.py: generates single-file HTML from cov.rpt + cov.txt
- Sidebar: function list sorted by coverage %, filterable by name
- Disasm tab: annotated disassembly with exec (green) / noexec (red) packets
- Call Graph tab: tree (callers, func, callees) with SVG layout
- Right-click drag to pan; depth input to control tree depth
- Per-test filtering: shows only functions exercised by selected test
- Per-test view: dropdown to switch between global (all tests) and individual test
- Sidebar re-sorts by per-test coverage; call graph shows only exercised functions
- Makefile.coverage: reorganize coverage artifacts into cov/ subdir
- $(INSTALLPATH)/cov/cov_fns: generated from libh2kernel.a + libh2.a
- $(INSTALLPATH)/cov/cov.txt: merged per-test coverage
- $(INSTALLPATH)/cov/cov.rpt: coverage report
- $(INSTALLPATH)/cov.html: interactive report (stays at top level)
- merge_cov.py: read cov_fns from installpath/cov/; preserve continuation lines
- gen_cov_fns.pl: scan both libh2kernel.a and libh2.a; filter LLVM clones
- makefile: remove stale cov_fns target; h2_cov now builds cov.html
- Makefile.inc.test: update clean_top for new cov/ paths
Signed-off-by: Zeev Belinsky <zbelinsk@qti.qualcomm.com>
stzahi1
reviewed
Jun 23, 2026
stzahi1
left a comment
stzahi1
left a comment
Contributor
There was a problem hiding this comment.
Looks OK but let's merge after you present on weekly.
Contributor
Author
Ok, thank you |
Add a Coverage build and verify step to the CI workflow that runs make cov TARGET=ref_cov to exercise the entire coveragepipeline (gen_cov_fns.pl, gen_cov_files.py, merge_cov.py, cov_rpt_tool, cov_html_report.py). This ensures the pipeline doesn't silently break during development. Signed-off-by: Zeev Belinsky <zbelinsk@qti.qualcomm.com>
Signed-off-by: zbelinsk <zbelinsk@qti.qualcomm.com>
Add scripts/cov_omit_functions, a source-controlled list of functions we deliberately do not cover. gen_cov_fns.pl drops these names from cov_fns so they never reach cov.txt / cov.rpt / cov.html. cov_html_report.py: - Filter trivial functions (<= 1 packet, always 0% or 100%) from the report. - Treat committed omits (cov_omit_functions) as "just not in the coverage": drop them from funcs so they never appear as a sidebar entry, call-graph node/edge, per-test data, or a restorable item -- keeping the report self-consistent even when run against a cov.rpt that still lists them. - Per-function Omit button: session omits accumulate in localStorage, stay flagged/restorable in both global and per-test views, and feed a downloadable updated cov_omit_functions to commit. Makefile.coverage: pass the omit file to gen_cov_fns.pl and cov_html_report.py, and add the dependencies so editing the list regenerates the report. Signed-off-by: Zeev Belinsky <zbelinsk@qti.qualcomm.com>
Signed-off-by: zbelinsk <zbelinsk@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an interactive single-file HTML coverage report with per-test drill-down and bidirectional call graphs.
Changes
cov/subdir;cov.htmlstays at top levelcov_fnsfrominstallpath/cov/; preserve continuation linescov_fnstarget;h2_covnow buildscov.htmlscripts/vXX{ref,opt}_cov_fnsfilesVerification
Build and open the report:
Test per-test view by selecting a test from the dropdown; sidebar and call graph update to show only that test's coverage.