elf: rename sh_line to sh_link in h2_elf.h#60
Merged
Conversation
sh_link is the standard ELF field name; sh_line was a typo introduced when h2_elf.h was hand-typed to avoid GPL/Solaris elf.h headers. Update the one call site in h2_elf.ref.c and the two notes files that referenced the old name. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Erich Plondke <erich@qti.qualcomm.com>
| Elf32_Off sh_offset; | ||
| Elf32_Word sh_size; | ||
| Elf32_Word sh_line; | ||
| Elf32_Word sh_link; |
There was a problem hiding this comment.
we can just use #include <elf.h> ?
Contributor
Author
There was a problem hiding this comment.
At the time we wanted things to be very separated. Not sure where elf.h comes from or what license it has... so back in the day we just reimplemented it.
Contributor
Author
|
All checks pass and I think this is a pretty trivial typo fix... merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sh_link is the standard ELF field name; sh_line was a typo introduced when h2_elf.h was hand-typed to avoid GPL/Solaris elf.h headers. Update the one call site in h2_elf.ref.c and the two notes files that referenced the old name.