Skip to content

feat: Introducing v1 and v2 hardware support for libqcperf#4

Draft
akshay-khalatkar wants to merge 2 commits intoqualcomm:mainfrom
akshay-khalatkar:feature/thermal-zone-x1
Draft

feat: Introducing v1 and v2 hardware support for libqcperf#4
akshay-khalatkar wants to merge 2 commits intoqualcomm:mainfrom
akshay-khalatkar:feature/thermal-zone-x1

Conversation

@akshay-khalatkar
Copy link
Copy Markdown
Contributor

Feature - Introducing v1 and v2 hardware support for power and thermal capabilities
Compilation - Compilation flags for v1 and v2 device support
Bug fix :

  1. GENERIC_READ | GENERIC_WRITE → GENERIC_READ — This is opening a device handle (via symbolic link) for thermal zone telemetry. It only needs read access to
    query sensor data. Requesting write access is unnecessary and may cause the open to fail if the driver doesn't grant write permissions.
  2. 0 → FILE_SHARE_READ | FILE_SHARE_WRITE — The old share mode of 0 demanded exclusive access, preventing any other process from opening the same device
    simultaneously. For a monitoring/telemetry device, shared access is correct — multiple consumers should be able to read from it concurrently.
  3. CREATE_ALWAYS → OPEN_EXISTING — This is a device, not a regular file. CREATE_ALWAYS attempts to create or truncate a file, which is semantically wrong for a
    device driver interface. OPEN_EXISTING is the correct disposition for opening an already-present device via its symbolic link.

@akshay-khalatkar akshay-khalatkar changed the title Feature: Introducing v1 and v2 hardware support for libqcperf feat: Introducing v1 and v2 hardware support for libqcperf Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant