Fix windows tests#52
Merged
jeromehaxhiaj-qti merged 3 commits intoqualcomm:mainfrom May 6, 2026
Merged
Conversation
markfoodyburton
approved these changes
May 6, 2026
Contributor
markfoodyburton
left a comment
markfoodyburton
left a comment
There was a problem hiding this comment.
I'd like Mahmoud to review too
mahmdkamel
reviewed
May 6, 2026
The helper was only searched next to the running executable, which fails when tests run from subdirectories. Fall back to SearchPathA so the helper is found via PATH (prepended by the test harness). Escalate spawn failure from a warning to SCP_FATAL to catch misconfigurations immediately instead of silently leaking temp DLLs. Signed-off-by: Jerome Haxhiaj <jhaxhiaj@qti.qualcomm.com>
The on_partner_exit callback only logged the event but never actually exited, leaving remote.exe orphaned after tests complete. Call _Exit() so the process terminates promptly when the parent is gone. Signed-off-by: Jerome Haxhiaj <jhaxhiaj@qti.qualcomm.com>
Suppresses -Winconsistent-missing-override warning. Signed-off-by: Jerome Haxhiaj <jhaxhiaj@qti.qualcomm.com>
jeromehaxhiaj-qti
force-pushed
the
fix_windows_tests
branch
from
2d13f8b to
920774e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.