cmake: Use system-installed libzip instead of building from source#55
Draft
jeromehaxhiaj-qti wants to merge 1 commit intoqualcomm:mainfrom
Draft
cmake: Use system-installed libzip instead of building from source#55jeromehaxhiaj-qti wants to merge 1 commit intoqualcomm:mainfrom
jeromehaxhiaj-qti wants to merge 1 commit intoqualcomm:mainfrom
Conversation
Replace the CPM-fetched libzip with find_package via pkg-config, requiring libzip to be pre-installed on the host. This speeds up configuration and avoids building libzip from source in-tree. Changes: - Use pkg_check_modules(LIBZIP) instead of CPM fetch, avoiding broken CMake config files shipped by Ubuntu's libzip-dev (which reference tool binaries from the missing libzip-tools package) - Add libzip to install_dependencies.sh for all supported platforms (Ubuntu, MSYS2, macOS) - Set BUILD_SHARED_LIBS=ON explicitly, since CPM-fetched libzip was previously setting this as a side effect via its option() call; without it, SystemC defaults to static on Windows, causing multiple-definition errors when plugin DLLs link against both libqbox.dll and libsystemc.a - Remove unused #include <zipint.h> (internal libzip header not available in the system package) Signed-off-by: Jerome Haxhiaj <jhaxhiaj@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the CPM-fetched libzip with find_package via pkg-config,
requiring libzip to be pre-installed on the host. This speeds up
configuration and avoids building libzip from source in-tree.
Changes:
CMake config files shipped by Ubuntu's libzip-dev (which reference
tool binaries from the missing libzip-tools package)
(Ubuntu, MSYS2, macOS)
previously setting this as a side effect via its option() call;
without it, SystemC defaults to static on Windows, causing
multiple-definition errors when plugin DLLs link against both
libqbox.dll and libsystemc.a
available in the system package)
Signed-off-by: Jerome Haxhiaj jhaxhiaj@qti.qualcomm.com