Skip to content

Change the default units to their dimensional version#82

Merged
NoureldinYosri merged 4 commits into
mainfrom
dim_units
Dec 19, 2025
Merged

Change the default units to their dimensional version#82
NoureldinYosri merged 4 commits into
mainfrom
dim_units

Conversation

@NoureldinYosri

@NoureldinYosri NoureldinYosri commented Dec 19, 2025

Copy link
Copy Markdown
Collaborator

the units exported at the top level of tunits didn't have the dimension information because of backwards compatibility ... this PR changes that

part of b/411725412

@mhucka mhucka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoureldinYosri NoureldinYosri merged commit b5c32f7 into main Dec 19, 2025
18 of 20 checks passed
@NoureldinYosri NoureldinYosri deleted the dim_units branch December 19, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants