This repository was archived by the owner on Feb 3, 2024. It is now read-only.
Use completion settings, not Preferences#68
Open
mitchr wants to merge 2 commits intoquarnster:masterfrom
Open
Conversation
Preferences.sublime-settings was previously used for completion variables. It makes more sense to use completion.sublime-settings.
Owner
|
Well, no, because then you won't have .sublime-project settings respected (which are queried via view.settings()). You are correct however that it should fallback to completion settings if no view settings are set. I think a helper function is in order which pretty much does (untested) |
|
Sorry for asking here, but i don't see issue category. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preferences.sublime-settings was previously used for completion
variables. It makes more sense to use completion.sublime-settings.