Skip to content
This repository was archived by the owner on Dec 13, 2019. It is now read-only.

feat: devserver shall be capable to open app not only in default sys… #220

Open
jerome-mare wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: devserver shall be capable to open app not only in default sys… #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/dev-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ const

let alreadyNotified = false

function openBrowser (url) {
function openBrowser (url, options = {}) {
const opn = require('opn')
opn(url)
opn(url, options)
}

module.exports = class DevServer {
Expand Down Expand Up @@ -53,7 +53,8 @@ module.exports = class DevServer {
alreadyNotified = true

if (cfg.devServer.open && ['spa', 'pwa'].includes(cfg.ctx.modeName)) {
openBrowser(cfg.build.APP_URL)
const browser = cfg.browser || {}
openBrowser(cfg.build.APP_URL, browser)
}
})
})
Expand Down Expand Up @@ -241,7 +242,8 @@ module.exports = class DevServer {
server.listen(cfg.devServer.port, cfg.devServer.host, () => {
resolve()
if (cfg.devServer.open) {
openBrowser(cfg.build.APP_URL)
const browser = cfg.browser || {}
openBrowser(cfg.build.APP_URL, browser)
}
})
})
Expand Down