fix(QInput,QField): expose error state to assistive tech#18323
Open
web3blind wants to merge 1 commit into
Open
fix(QInput,QField): expose error state to assistive tech#18323web3blind wants to merge 1 commit into
web3blind wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17306.
This adds the missing ARIA error-state relationship for Quasar fields so assistive technologies can identify invalid controls and reach the rendered error message.
What changed
aria-invalid="true",aria-errormessage, andaria-describedbyto nativeQInputcontrols in error state.aria-describedbyvalues instead of replacing them.ariaInvalid,ariaDescribedby, andariaErrormessagein theQFieldcontrol slot scope so custom controls can wire the same relationship.Validation
pnpm --filter quasar buildpnpm --filter quasar test -- --run ui/src/components/input/QInput.test.js ui/src/components/field/QField.test.jsTest Files 101 passed (101)Tests 1063 passed (1063)pnpm exec oxlint --no-error-on-unmatched-pattern ui/src/components/input/QInput.js ui/src/composables/private.use-field/use-field.js ui/src/components/input/QInput.test.js ui/src/components/field/QField.test.jsFound 0 warnings and 0 errors.git diff --checkNote: full
pnpm lint:ui:checkwas blocked in my local checkout by a generated-file/environment issue unrelated to these changes:ui/playground/.quasar/tsconfig.jsonwas missing.