fix: restore QDrawer swipe-to-open guard inverted in v2.20.0 (fix #18331)#18332
Closed
128na wants to merge 1 commit into
Closed
fix: restore QDrawer swipe-to-open guard inverted in v2.20.0 (fix #18331)#18332128na wants to merge 1 commit into
128na wants to merge 1 commit into
Conversation
…asarframework#18331) onOpenPan()'s early-return guard was changed from "if (showing.value !== false) return" to "if (!showing.value) return" between v2.19.3 and v2.20.0, inverting its meaning. This made the edge-swipe-to-open gesture a no-op whenever the drawer was closed, i.e. exactly the case it's meant to handle, breaking mobile swipe-open entirely.
Member
|
Ahhhh.. saw the PR after fixing it myself. Sorry :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)fix: #xxx[,#xxx], where "xxx" is the issue number)Other information:
Fixes #18331
onOpenPan()'s early-return guard inQDrawer.jswas inverted between v2.19.3 and v2.20.0, breaking the edge-swipe-to-open gesture whenever the drawer is closed (exactly the case it's meant to handle).v2.19.3 (correct):
v2.20.0 / v2.20.1 / dev (broken, before this PR):
showing.value !== false(skip only when already showing) was changed to!showing.value(skip when not showing) — the exact logical opposite, so the swipe-to-open gesture became a no-op while the drawer was closed.This PR reverts the guard back to the v2.19.3 behaviour, with no other functional change.
Reproduction
Live reproduction (broken on current
quasar@2, confirmed fixed when pinned to2.19.3): https://jsfiddle.net/ytma3qLn/Steps:
q-drawerforced into mobile/swipe mode viabreakpoint="9999", starting closed).