Skip to content

Conversation

@trisketz
Copy link

I also added in backup files for a small handful of page sites, hope that is ok.

@mdlama
Copy link
Member

mdlama commented Apr 13, 2021

Hi, Jenny! It looks like there are more places in the code where changes need to be made. I did a search across the codebase for autosubscribe and came up with the following list of files that need some changes:

  • /components/com_groups/site/views/emails/tmpl/saved.php
  • /components/com_groups/site/views/emails/tmpl/saved_plain.php
  • /components/com_groups/site/controllers/groups.php
  • /components/com_groups/models/import.php
  • /components/com_groups/admin/views/manage/tmpl/edit.php
  • /components/com_groups/admin/views/imports/tmpl/_fieldmap.php
  • /components/com_groups/admin/controllers/manage.php

There are likely other files as well, for example here is one more from the plugin:

  • /plugins/groups/forum/forum.xml (default params for plugin)

Let's talk in our meeting today to map out next steps.

@trisketz
Copy link
Author

trisketz commented Apr 24, 2021

Hi, Jenny! It looks like there are more places in the code where changes need to be made. I did a search across the codebase for autosubscribe and came up with the following list of files that need some changes:

  • /components/com_groups/site/views/emails/tmpl/saved.php
  • Believe this is allowing comments on groups (group settings page)
  • Testing on live webdev suggests we do not receive emails when someone comments on a page
  • /components/com_groups/site/views/emails/tmpl/saved_plain.php
  • Same as above
  • [] /components/com_groups/site/controllers/groups.php
  • Creating new group/editing group settings. Comment out
  • Creating a new group was not affected - if new forums were not set up, it did not let you select a digest however. Bug.
  • /components/com_groups/models/import.php
  • Commented out
  • /components/com_groups/admin/views/manage/tmpl/edit.php
  • Here we get an issue from the admin when I comment out lines 32-41 from ROOT/core/libraries/Hubzero/View/View.php:531
  • Commenting out the lines that creates the section in the view to turn on emails for groups in the admin was fine

Screen Shot 2021-04-24 at 3 27 35 PM

  • /components/com_groups/admin/views/imports/tmpl/_fieldmap.php
  • Commented out
  • /components/com_groups/admin/controllers/manage.php
  • Commented out

There are likely other files as well, for example here is one more from the plugin:

  • /plugins/groups/forum/forum.xml (default params for plugin)

Let's talk in our meeting today to map out next steps.

I'll move forward for figuring out the bug. I also need to look at this xml file. But I am unsure at the moment what we want to do with the /components/com_groups/admin/views/manage/tmpl/edit.php file. It's for the admin and I can remove the section to let admins change email settings in the view. I can look further into the core library to see what that file does.

@trisketz
Copy link
Author

  • Here we get an issue from the admin when I comment out lines 32-41 from ROOT/core/libraries/Hubzero/View/View.php:531
  • Commenting out the lines that creates the section in the view to turn on emails for groups in the admin was fine

I lied. If I take out the lines that creates the section in the view completely instead of commenting it out, there is no error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants