Draft
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
========================================
- Coverage 96.1% 93.2% -2.9%
========================================
Files 13 14 +1
Lines 1676 1765 +89
========================================
+ Hits 1611 1646 +35
- Misses 65 119 +54
Continue to review full report at Codecov.
|
goerz
force-pushed
the
master
branch
2 times, most recently
from
28e1367 to
e9754de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for parametrized pulses by attaching an optional 'parametrization' attribute to control-functions and pulse arrays. The parametrization object stored in that attribute contains information for converting ϵ⟷u and calculating the derivative ∂ϵ/∂u. These are automatically taking into account when calculating the pulse updates (μ = (∂Ĥ/∂ϵ)⋅(∂ϵ/∂u) for an Ĥ that is linear in ϵ).
Thus, all internal storage is for the physical pulse values ϵ(t), and any conversion to u(t) is done on the fly as necessary. This ensures that everything stays 100% compatible with QuTiP, but adds a small overhead from the ϵ⟷u conversions compared to the "hacky" solution discussed in #23 (comment). The latter could still be used by an advanced user when performance is more critical than clarity.
Closes #23