Fix memory allocation issue for ci textures#18
Open
MegaMech wants to merge 9 commits intoqueueRAM:masterfrom
Open
Fix memory allocation issue for ci textures#18MegaMech wants to merge 9 commits intoqueueRAM:masterfrom
MegaMech wants to merge 9 commits intoqueueRAM:masterfrom
Conversation
Author
|
CI4 likely needs a bit of testing. However, CI8s should be working properly now. |
Author
|
I think I just need to modify the documentation a bit and then this PR is good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
This results in a memory next error. Due to this line:
It's still using the default of 32x32 to allocate memory. However, this texture is 128x32. Therefore, we need to read the .png's dimension metadata earlier to allocate memory based on that.
Adds
-margument (stands for magic number or magic filler) to specify what value to fill palettes with. This way the tail end of the palette will match.