AcceptanceTestSuite: suppress logs per test, only emit on failure#1218
Draft
Copilot wants to merge 9 commits into
Draft
AcceptanceTestSuite: suppress logs per test, only emit on failure#1218Copilot wants to merge 9 commits into
AcceptanceTestSuite: suppress logs per test, only emit on failure#1218Copilot wants to merge 9 commits into
Conversation
…fails Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/99e20c76-25aa-48fe-a4b9-2b31fe241caf Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…ngLogHandler Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/99e20c76-25aa-48fe-a4b9-2b31fe241caf Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
chrjohn
May 7, 2026 11:02
View session
AcceptanceTestSuite: suppress logs per test, only emit on failure
chrjohn
reviewed
May 7, 2026
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/6e91f3ee-2d32-4ee6-8944-fe80549dbe1c Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
chrjohn
reviewed
May 7, 2026
Member
|
@copilot |
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/faabc07d-e156-400b-8cdc-65ee38b97453 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Contributor
Author
Done in d784f8d. Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AcceptanceTestSuiteemits voluminous INFO-level logs for every test case, making CI output noisy and failures harder to diagnose.Approach
Buffer all
java.util.loggingoutput during each individual test and replay it only when that test fails. Log suppression can be disabled via a system property for debugging purposes.Changes
CapturingLogHandler(new inner static class) — a JULHandlerthat accumulatesLogRecords in a synchronizedArrayList;drainRecords()atomically snapshots and clears the buffer.AcceptanceTest.run()— wraps each test execution with log capture:"Running test {}, filename : {}"line before suppression begins, so test progress is always visible.OFFbefore the test runs.CapturingLogHandleron the root logger.-Datest.verbose=truesystem property — when set, bypasses the log-capturing/suppression block entirely so all logs flow normally to the existing handlers. Follows the same convention as-DskipATand-Datest.skipslow. Default isfalse(suppress per-test, replay only on failure).No new dependencies — uses only
java.util.loggingAPIs.