Backport SessionScheduleTest coverage for previous-day start-of-week handling#1225
Draft
Copilot wants to merge 7 commits into
Draft
Backport SessionScheduleTest coverage for previous-day start-of-week handling#1225Copilot wants to merge 7 commits into
SessionScheduleTest coverage for previous-day start-of-week handling#1225Copilot wants to merge 7 commits into
Conversation
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/ef6ae2c0-e37a-470b-844b-0b3669bf49e0 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/ef6ae2c0-e37a-470b-844b-0b3669bf49e0 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/fd599c00-e171-4397-ba2a-55d22de77d69 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/ac53da8d-957c-49ef-82c3-1e528a9fc119 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…sion Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/86d191b3-7848-4e01-9557-1c6bc19cb837 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/d264a768-54d3-4d1c-aa57-93785bc1f619 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
chrjohn
May 16, 2026 19:24
View session
Member
|
@copilot LogUtilTest.testLogThrowable:51 fails |
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/6e680b34-2576-43e6-8a75-bcadbffdd3df Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR copies over the missing
SessionScheduleTestcase covering a schedule that starts in one timezone/day context and ends in another. It preserves regression coverage forStartDayresolution when locale week boundaries can shift how the session window is interpreted.Added regression coverage
testSessionStartInPreviousDayOfWeek()intoquickfixj-core/src/test/java/quickfix/SessionScheduleTest.java.StartTime=13:00:00 Australia/VictoriaStartDay=SundayEndTime=17:00:00 America/New_YorkEndDay=SaturdayEdge case under test
Locale("en", "AU").DefaultSessionSchedule.isSessionTime()remains correct when the effective session start can resolve into the previous day-of-week.Why this matters