Merged
Conversation
Member
|
Seems reasonable. It's possible someone out there is using QS to relaunch hung XPC processes or kill Microsoft / Chrome AutoUpdater or what have you, but seems pretty unlikely; I don't see any issues mentioning "xpc" that don't seem to be about crashes or hangs, so this seems like a net win. If there are complaints, I imagine we could add a setting to reenable this, but I think the default should be off (80/20 rule). Thanks as always for quick action! |
Member
Author
|
Thanks! Sounds good. I think if people really want to relaunch XPC apps, then they can just enable 'show background processes'. No need for an extra setting ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few extra tweaks to the previous PR. We don't only want to show NSBundle type apps (because command line apps are legitimate 'foreground apps' - especially if they have GUIs. But we also don't want to show background apps (esp the safari xpc apps). So I've added an additional check for XPC here and removed the previous check that only allowed NSBundles through.