Conversation
…I and a potential deadlock
Sometimes, opening the prefs pane with ⌘, would not consistently bring the window to the front
If already on the main thread - it's a no-op so speeds up activation (avoids a 'laggy' feeling in some cases)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR includes minor optimizations and fixes to improve performance and resolve a deadlock issue in Quicksilver's interface handling.
Changes:
- Optimizes
insertSpaceto defer object resolution until needed - Moves indirect object resolution to a background thread to prevent deadlock
- Updates Bezel interface to use autolayout with adjusted spacing
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| QSBezelInterfaceController.m | Moves standardRect calculation after autolayout and updates window sizing logic to use autolayout-computed positions |
| QSBezelInterface.xib | Enables autolayout with constraints for UI elements and updates spacing constants |
| QSMainMenuPrefPane.xib | Updates Interface Builder versions and screen resolution metadata |
| QSSearchObjectView.m | Optimizes insertSpace to defer object resolution and adds autolayout constraints for text editor |
| QSSearchObjectView.h | Adds textEditorConstraints property for managing autolayout |
| QSInterfaceController.m | Changes showMainWindow to use sync dispatch and moves indirect object resolution to background thread |
| QSPaths.h | Updates help search URL format |
| QSLibrarian.h | Fixes syntax error in import statement |
| QSPreferencesController.m | Fixes sporadic preferences pane opening behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@pjrobertson I've opened a new pull request, #3092, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
[WIP] WIP Address feedback from PR #3091 for minor improvements
Allows searching 'mail' to return 'E-Mail Support'
…might not want to show to the user E.g. text extracted from images
If this prooves to be too problematic then we can revert back
Previously, it would search in the whole QSLib, whereas it should only search actions
…QSObjectDefaultAction set Objects that have 'kQSObjectDefaultAction' set return an array of [DefaultAction, [All Actions]] for the valid list of actions This would break when using ⌘⇧<letter> combinations, that would try to iterate over all items in the outer array and fail on [All Actions] - since it's an array not an object The correct fix is to return the [All Actions] array alone if the length of the array is 2 and the 2nd item is an array.
…n the trigger sidebar pane
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
insertSpacebehaviour - to not resolve the dObject unless it's actually needed