(Huge PR) Refactor to support linkding and self-hosted delicious.#1
Open
rbdr wants to merge 11 commits intoquicksilver:mainfrom
Open
(Huge PR) Refactor to support linkding and self-hosted delicious.#1rbdr wants to merge 11 commits intoquicksilver:mainfrom
rbdr wants to merge 11 commits intoquicksilver:mainfrom
Conversation
Member
|
Wow, this is amazing, thanks! I haven't really used this plugin but I'll dig through and make sure it seems to work. If so would be happy to merge -- thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everybody! This is my first contribution to a QS plugin, and it's fairly sizeable as it rewrites most of the plugin. So I completely understand if that alone is a rejection 😬 .
I'll try to explain what changed, why and how to hopefully make it easier.
What Changed (As a user of the plugin)
What Changeed (In the code)
objectHasChildren:method so tags correctly get populated with children.Potential Improvements I would like to make.