This repository was archived by the owner on Nov 16, 2018. It is now read-only.
Return empty string when input is empty instead of 'Invalid Date' #148
Open
dehamilton wants to merge 1 commit intoquri:masterfrom
Open
Return empty string when input is empty instead of 'Invalid Date' #148dehamilton wants to merge 1 commit intoquri:masterfrom
dehamilton wants to merge 1 commit intoquri:masterfrom
Conversation
|
+1 |
|
this allows clearing the date, but I suggest a similar fix in the constructor for when you give an empty initial date/time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should resolve issue #122. Now instead of performing the formatting regardless of 'value' the formatting will only occur if the moment creation is valid. Otherwise it will return an empty string.