Add support to dense eigen on GPU
#609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Thank you for contributing to
QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.make test.juliaformatted by running:make format.docs/folder) related to code changes were updated and able to build locally by running:make docs.CHANGELOG.mdshould be updated (regarding to the code changes) and built by running:make changelog.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
The support to dense
eigensolvers was missing. The simple caseeigenstates(H_gpu)was not working due to missing methods forto_dense(::Type{CuSparseMatrix...}). That method was called inside theeigenfunction in order to force type stability on CPU (see JuliaLang/LinearAlgebra.jl#1498). However, this just gives a weakUniontype on Julia > v1.10, which is not a huge problem. However, this creates a type instability in Julia v1.10, but I think it can be kept like this since it is a problem of that version. So I have decided to remove this forcing type conversion and keep the code simpler.Since this now gives a
Uniontype, while the sparse solver doesn't, I have decided to useValfor thesparsekeyword argument, such that thesparse = Val(true)case doesn't return theUniontype.