Skip to content

Make fast.prcomp return a valid prcomp object#1

Merged
warnes merged 1 commit intor-gregmisc:masterfrom
DarwinAwardWinner:pca-fix
Dec 7, 2024
Merged

Make fast.prcomp return a valid prcomp object#1
warnes merged 1 commit intor-gregmisc:masterfrom
DarwinAwardWinner:pca-fix

Conversation

@DarwinAwardWinner
Copy link

Functions like predict.prcomp expect a prcomp object to have "center" and "scale" attributes. Without these attributes, predict.prcomp throws an error.

Functions like predict.prcomp expect a prcomp object to have "center"
and "scale" attributes.
Copy link
Member

@warnes warnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@warnes warnes merged commit cd66c41 into r-gregmisc:master Dec 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants