fix(docker): move deno libs aside during apk install#270
Merged
Conversation
Previous approach of removing all libs broke deno (missing libdl.so.2). Now moves /usr/local/lib out of the way during apk install and restores it after, so both apk triggers and deno work correctly. Also adds workflow_dispatch trigger to dev.yml for manual testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
denoland/deno:alpine-2.6.8shipping glibc-linked libs in/usr/local/lib//usr/local/libaside duringapk install, restore after — both apk triggers and Deno work correctlyworkflow_dispatchtrigger to dev workflow for manual build testingpull_requesteventsContext
Previous fixes attempted:
LD_LIBRARY_PATH=/usr/lib— fixedapkbut not post-install triggers (glib, shared-mime-info, gdk-pixbuf)rm -f /usr/local/lib/lib*.so*— fixed apk but broke Deno (missinglibdl.so.2)/usr/local/libout of the way during apk, restores afterUpstream issue: denoland/deno_docker#373
Verified via
workflow_dispatchbuild: both amd64 and arm64 pass.Test plan