Skip to content

Fix websec self-scan findings and false positives#21

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix-websec-self-scan-findings-17858821003781577430
Open

Fix websec self-scan findings and false positives#21
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix-websec-self-scan-findings-17858821003781577430

Conversation

@google-labs-jules

Copy link
Copy Markdown

This PR fixes several true and false positive findings flagged by websec run ..

  • Fixes the true positive docker-no-healthcheck finding by explicitly declaring a HEALTHCHECK in Dockerfile.
  • Fixes the false positive llm-guardrail-fail-open logic in src/websec_validator/extractors/llm_security.py by removing the overly aggressive greedy match (\w*) which flagged unrelated terms like Scanner and scan_dir. A regression test was added to verify it explicitly.
  • Suppresses false positives generated by other internal extractors (such as llm_security.py, authz.py, crypto_usage.py, transport_security.py) and findings.py in .websec-ignore with justifications, as they hold attack definitions explicitly.

PR created automatically by Jules for task 17858821003781577430 started by @raccioly

- Added HEALTHCHECK to Dockerfile (docker-no-healthcheck true positive).
- Tightened `GUARD_FN` regex in `llm_security.py` to fix llm-guardrail-fail-open false positives.
- Suppressed extractors with internal definitions in `.websec-ignore` to eliminate false positives.
@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants