Fix websec self-scan findings and false positives#21
Fix websec self-scan findings and false positives#21google-labs-jules[bot] wants to merge 1 commit into
Conversation
- Added HEALTHCHECK to Dockerfile (docker-no-healthcheck true positive). - Tightened `GUARD_FN` regex in `llm_security.py` to fix llm-guardrail-fail-open false positives. - Suppressed extractors with internal definitions in `.websec-ignore` to eliminate false positives.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes several true and false positive findings flagged by
websec run ..docker-no-healthcheckfinding by explicitly declaring aHEALTHCHECKinDockerfile.llm-guardrail-fail-openlogic insrc/websec_validator/extractors/llm_security.pyby removing the overly aggressive greedy match (\w*) which flagged unrelated terms likeScannerandscan_dir. A regression test was added to verify it explicitly.llm_security.py,authz.py,crypto_usage.py,transport_security.py) andfindings.pyin.websec-ignorewith justifications, as they hold attack definitions explicitly.PR created automatically by Jules for task 17858821003781577430 started by @raccioly