feat(mcp): cap + TTL the NonceStore#27
Merged
radiosilence merged 1 commit intomainfrom Apr 18, 2026
Merged
Conversation
The NonceStore added in #24 was an unbounded HashMap. A misbehaving MCP client that PREVIEW'd repeatedly without ever CONFIRM'ing could grow it without limit for the life of the process. Not exploitable (local, trusted caller) but not tidy either. Now bounded: - 15-minute TTL per nonce, swept on every issue and rejected on consume - Hard cap of 256 outstanding nonces, oldest evicted when full - Seven tests: roundtrip, missing, reuse, tampered params, expired, cap eviction, expired sweep Entries now carry an `issued_at: Instant` alongside the fingerprint; `Nonce` became a struct so the map type reflects what it holds. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #25. The `NonceStore` introduced in #24 was unbounded — PREVIEW without CONFIRM would grow the map forever. Low impact (trusted local MCP caller) but should still be bounded.
Changes
Why these numbers
Test plan
🤖 Generated with Claude Code