Skip to content

fix(sft): drop the cond cast deleted with loss_hub.utils - #107

Merged
Rockdu merged 1 commit into
radixark:mainfrom
Rockdu:fix/sft-cond-cast
Aug 8, 2026
Merged

fix(sft): drop the cond cast deleted with loss_hub.utils#107
Rockdu merged 1 commit into
radixark:mainfrom
Rockdu:fix/sft-cond-cast

Conversation

@Rockdu

@Rockdu Rockdu commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

What

Why

#90 (SFT) merged first and imports loss_hub.utils; #103 merged after and deleted it — both PRs were green, but every stage-a-cpu run on the merged main now fails at collection with ModuleNotFoundError. Boundary input dtypes are family input_dtype_policy territory since #103, and SFT batches flow through the same actor boundary; Wan declares no policy today, deliberately left as a separate family decision.

Checklist

  • pre-commit run --all-files passes
  • Added/updated tests for new behaviour — none needed: this restores collection of the existing test_loss_hub_sft.py
  • pytest -x is green — not run locally (no local torch); stage-a-cpu re-runs the suite
  • Remaining items — no flags/docs/examples touched

@Rockdu
Rockdu force-pushed the fix/sft-cond-cast branch from 7116181 to e5fe336 Compare August 8, 2026 08:39
@Rockdu Rockdu changed the title fix(sft): route cond and latent dtypes through the family input policy fix(sft): drop the cond cast deleted with loss_hub.utils Aug 8, 2026
@Rockdu
Rockdu force-pushed the fix/sft-cond-cast branch from e5fe336 to 8c89aaf Compare August 8, 2026 08:41
@Rockdu
Rockdu merged commit 8f31acb into radixark:main Aug 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant