Conversation
Implemented automatic column order validation and reordering for DataFrame inputs in the Model.predict() method: - Validates that all required features are present in input DataFrame - Automatically reorders columns to match expected feature order - Issues warning when columns are reordered or when using arrays - Raises ValueError if required features are missing - Handles extra columns by selecting only needed features - Works for both classifiers and regressors Added comprehensive tests covering: - Correct column order (no warning) - Incorrect column order (auto-reorder with warning) - Missing columns (raises error) - Extra columns (handled gracefully) - NumPy arrays (warns about assumed order) - Regressor support All 56 tests pass including 7 new tests for column order validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If column names were in the training data, coldsnap will now check if they are included in new data when predicting and ensure the order is correct.