Add support for building Linux binaries#70
Open
MigProPlayer wants to merge 2 commits intoraindropio:masterfrom
Open
Add support for building Linux binaries#70MigProPlayer wants to merge 2 commits intoraindropio:masterfrom
MigProPlayer wants to merge 2 commits intoraindropio:masterfrom
Conversation
…tectures Co-authored-by: MigProPlayer <86320279+MigProPlayer@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds CI and build configuration to produce multiple Linux package formats (deb/rpm/AppImage) in addition to the existing snap build, and uploads the resulting artifacts from the Linux workflow.
Changes:
- Expanded
electron-builderLinux targets to builddeb,rpm,AppImage(x64 + arm64) andsnap(x64). - Updated
.github/workflows/linux.ymlto useactions/checkout@v4andactions/setup-node@v4, installrpm, and upload build outputs as workflow artifacts. - Standardized Linux artifact naming via
artifactNamesettings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
build/config.js |
Adds multi-target/multi-arch Linux packaging configuration and artifact naming for deb/rpm/AppImage/snap. |
.github/workflows/linux.yml |
Updates actions versions, installs RPM tooling, publishes snap, and uploads generated Linux artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Author
|
Slight suggestion while you're at it: Currently the .desktop file includes the Science category, in my opinion it should be removed and instead added to the Office category (called Productivity on some systems), which I think fits Raindrop better. Just my opinion though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for building Linux binaries beyond just snap packages.
debs,rpms andAppImages alongsidesnappackages.actions/checkoutandactions/setup-nodewere also updated to use the latest v4 versions.All generated builds were tested and confirmed working, all showing name and icon on the app list and with login functionality also working (as well as the app itself).
CI/CD workflow updates:
actions/checkoutandactions/setup-nodein.github/workflows/linux.ymlto use the latest v4 versions for improved performance and support.rpmpackage) in the workflow.Linux packaging enhancements:
build/config.jsto support building for multiple Linux targets:deb,rpm,AppImage(all for x64 and arm64), andsnap(x64 only).deb,rpm,appImage,snap) to use a consistent artifact naming convention:Raindrop-${arch}.${ext}.Artifact management:
.deb,.rpm,.AppImage,.snap) after the build for easy access.