Refactor dg api model to pydantic #522#523
Draft
joshdimanteto wants to merge 7 commits intoupgrade-to-pydantic-V2-#520from
Draft
Refactor dg api model to pydantic #522#523joshdimanteto wants to merge 7 commits intoupgrade-to-pydantic-V2-#520from
joshdimanteto wants to merge 7 commits intoupgrade-to-pydantic-V2-#520from
Conversation
1433a3d to
3b7621f
Compare
3b7621f to
f0b4bf6
Compare
joshdimanteto
commented
Jan 16, 2026
- add TODO for issue found with post and patch requesr #525
fd2f29c to
cc387dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will close #522
Description
Refactor the SQL models to use pydantic
Generate the models use the SQL received from the icat server
Fix the models for the post and patch requests
Testing Instructions
Add a set up instructions describing how the reviewer should test the code
icatdb Generator Script Consistency TestCI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:,feat:orBREAKING CHANGE:so a release is automatically made via GitHub Actions upon merge?Agile Board Tracking
Closes #522